pam: replace Hacking.md with a proper README.md#1468
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1468 +/- ##
==========================================
- Coverage 87.10% 87.07% -0.04%
==========================================
Files 93 93
Lines 6367 6367
Branches 111 111
==========================================
- Hits 5546 5544 -2
- Misses 765 767 +2
Partials 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
denisonbarbosa
approved these changes
Apr 16, 2026
Member
denisonbarbosa
left a comment
denisonbarbosa
left a comment
There was a problem hiding this comment.
Looks pretty solid to me
The old Hacking.md was developer-focused, informal, and incomplete (e.g. it lacked coverage of the three runtime UI modes and the running-tests section). Replace it with a conventional README.md that gives newcomers a clearer mental model of the module's architecture (binary implementations + runtime UI modes), documents the directory layout, and presents build, testing, and troubleshooting instructions in a consistent, polished style.
nooreldeenmansour
approved these changes
Apr 17, 2026
3v1n0
reviewed
Apr 17, 2026
3v1n0
reviewed
Apr 17, 2026
nooreldeenmansour
added a commit
that referenced
this pull request
Apr 17, 2026
Add extra flags for PAM module troubleshooting `--exec-debug` and `--exec-log` as suggested by in #1468
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old Hacking.md was developer-focused, informal, and incomplete (e.g. it lacked coverage of the three runtime UI modes and the running-tests section). Replace it with a conventional README.md that gives newcomers a clearer mental model of the module's architecture (binary implementations + runtime UI modes), documents the directory layout, and presents build, testing, and troubleshooting instructions in a consistent, polished style.
UDENG-9813