Allow NaN, Infinity values for quantities#1289
Merged
angularsen merged 5 commits intoangularsen:release/v6from Dec 30, 2023
Merged
Allow NaN, Infinity values for quantities#1289angularsen merged 5 commits intoangularsen:release/v6from
angularsen merged 5 commits intoangularsen:release/v6from
Conversation
Add possibility to have double.NaN, double.NegativeInifinity and double.PositiveInifnity special values.
Owner
|
Changed this to target v6 branch. |
angularsen
requested changes
Jul 16, 2023
Owner
angularsen
left a comment
angularsen
left a comment
There was a problem hiding this comment.
Moved this to v6 branch, primarily to give it more time to mature and have some time for people to discuss the change before we make it official.
Would also like to keep the tests, but change them to test that nan/inf is allowed.
angularsen
added
the
pending-response
angularsen
changed the title
Owner
|
Lol, better late than never :D Nice! |
angularsen
added a commit
that referenced
this pull request
Feb 23, 2024
I think this was forgotten in #1289, removes 3k+ lines of comments that are not true anymore. --------- Co-authored-by: Andreas Gullberg Larsen <andreas.larsen84@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add possibility to have double.NaN, double.NegativeInifinity and double.PositiveInifnity special values.